Adding DscExamplesPresent rule #95
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| /// <returns>The results of the analysis</returns> | ||
| public IEnumerable<DiagnosticRecord> AnalyzeDSCResource(Ast ast, string fileName) | ||
| { | ||
| String fileNameOnly = fileName.Substring(fileName.LastIndexOf("\\", StringComparison.Ordinal) + 1); |
There was a problem hiding this comment.
We should use Path.GetFileName("fileName")
| if (!examplesPresent) | ||
| { | ||
| yield return new DiagnosticRecord(string.Format(CultureInfo.CurrentCulture, Strings.DscExamplesPresentNoExamplesError, resourceName), | ||
| null, GetName(), DiagnosticSeverity.Information, fileName); |
There was a problem hiding this comment.
We may want to use the dscClass.Extent here for the extent instead of null
|
Looks good to me. |
quoctruong
pushed a commit
that referenced
this pull request
May 6, 2015
Adding DscExamplesPresent rule
|
Merged pull request |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adding DscExamplesPresent rule (addressing Issue #84 )
DscExamplesPresent: Checks that DSC examples for given resource are present.
Rule expects directory Examples to be present:
For non-class based resources it should exist at the same folder level as DSCResources folder.
For class based resources it should be present at the same folder level as resource psm1 file.
Examples folder should contain sample configuration for given resource - file name should contain resource's name.